From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: falcon: remove unwarranted safety check in dma_load
Date: Tue, 03 Mar 2026 13:55:12 +1000 [thread overview]
Message-ID: <review-patch5-20260301-turing_prep-v10-5-dde5ee437c60@nvidia.com> (raw)
In-Reply-To: <20260301-turing_prep-v10-5-dde5ee437c60@nvidia.com>
Patch Review
Removes the assertion that DMA loading cannot be used with firmware that has a non-secure IMEM section:
```rust
- if fw.imem_ns_load_params().is_some() {
- debug_assert!(false);
- return Err(EINVAL);
- }
```
The commit message explains this was an assumption about firmware usage patterns, not a hardware limitation. This removal is needed for the generic bootloader flow where DMA-loadable firmware may have NS IMEM sections. Reasonable.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 3:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 14:03 [PATCH v10 00/10] gpu: nova-core: add Turing support Alexandre Courbot
2026-03-01 14:03 ` [PATCH v10 01/10] gpu: nova-core: create falcon firmware DMA objects lazily Alexandre Courbot
2026-03-03 3:55 ` Claude review: " Claude Code Review Bot
2026-03-01 14:03 ` [PATCH v10 02/10] gpu: nova-core: falcon: add constant for memory block alignment Alexandre Courbot
2026-03-03 3:55 ` Claude review: " Claude Code Review Bot
2026-03-01 14:03 ` [PATCH v10 03/10] gpu: nova-core: falcon: rename load parameters to reflect DMA dependency Alexandre Courbot
2026-03-02 4:54 ` Eliot Courtney
2026-03-02 5:24 ` Alexandre Courbot
2026-03-03 3:55 ` Claude review: " Claude Code Review Bot
2026-03-01 14:03 ` [PATCH v10 04/10] gpu: nova-core: falcon: remove FalconFirmware's dependency on FalconDmaLoadable Alexandre Courbot
2026-03-03 3:55 ` Claude review: " Claude Code Review Bot
2026-03-01 14:03 ` [PATCH v10 05/10] gpu: nova-core: falcon: remove unwarranted safety check in dma_load Alexandre Courbot
2026-03-03 3:55 ` Claude Code Review Bot [this message]
2026-03-01 14:03 ` [PATCH v10 06/10] gpu: nova-core: move brom_params and boot_addr to FalconFirmware Alexandre Courbot
2026-03-03 3:55 ` Claude review: " Claude Code Review Bot
2026-03-01 14:03 ` [PATCH v10 07/10] gpu: nova-core: add PIO support for loading firmware images Alexandre Courbot
2026-03-03 3:55 ` Claude review: " Claude Code Review Bot
2026-03-01 14:03 ` [PATCH v10 08/10] gpu: nova-core: use the Generic Bootloader to boot FWSEC on Turing Alexandre Courbot
2026-03-02 7:22 ` Eliot Courtney
2026-03-03 3:55 ` Claude review: " Claude Code Review Bot
2026-03-01 14:03 ` [PATCH v10 09/10] gpu: nova-core: make Chipset::arch() const Alexandre Courbot
2026-03-03 3:55 ` Claude review: " Claude Code Review Bot
2026-03-01 14:03 ` [PATCH v10 10/10] gpu: nova-core: add gen_bootloader firmware to ModInfoBuilder Alexandre Courbot
2026-03-03 3:55 ` Claude review: " Claude Code Review Bot
2026-03-03 3:55 ` Claude review: gpu: nova-core: add Turing support Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-06 4:52 [PATCH v11 00/12] " Alexandre Courbot
2026-03-06 4:52 ` [PATCH v11 07/12] gpu: nova-core: falcon: remove unwarranted safety check in dma_load Alexandre Courbot
2026-03-08 23:15 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260301-turing_prep-v10-5-dde5ee437c60@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox