From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: falcon: remove unwarranted safety check in dma_load Date: Tue, 03 Mar 2026 13:55:12 +1000 Message-ID: In-Reply-To: <20260301-turing_prep-v10-5-dde5ee437c60@nvidia.com> References: <20260301-turing_prep-v10-0-dde5ee437c60@nvidia.com> <20260301-turing_prep-v10-5-dde5ee437c60@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Removes the assertion that DMA loading cannot be used with firmware that has a non-secure IMEM section: ```rust - if fw.imem_ns_load_params().is_some() { - debug_assert!(false); - return Err(EINVAL); - } ``` The commit message explains this was an assumption about firmware usage patterns, not a hardware limitation. This removal is needed for the generic bootloader flow where DMA-loadable firmware may have NS IMEM sections. Reasonable. No issues. --- Generated by Claude Code Patch Reviewer