From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: clarify invariant on command queue Date: Thu, 05 Mar 2026 13:55:44 +1000 Message-ID: In-Reply-To: <20260304-cmdq-continuation-v5-5-3f19d759ed93@nvidia.com> References: <20260304-cmdq-continuation-v5-0-3f19d759ed93@nvidia.com> <20260304-cmdq-continuation-v5-5-3f19d759ed93@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds a comment explaining why only `dst.contents.0` is used for extracting the command header. This is a documentation-only change. The comment: ```rust // Extract area for the command itself. The GSP message header and the command header // together are guaranteed to fit entirely into a single page, so it's ok to only look // at `dst.contents.0` here. ``` This relies on the fact that `GspMsgElement` + any `Command` struct together fit in `GSP_PAGE_SIZE` (4096 bytes). This is a reasonable assumption for the fixed-size command headers currently in use, but worth noting this would break if a `Command` struct ever exceeded ~4KB. The invariant is implicitly enforced by the fact that the queue element starts page-aligned and `GspMsgElement::from_bytes_mut_prefix` splits at the element boundary. --- Generated by Claude Code Patch Reviewer