From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: bus: mhi: Add QDU100 firmware image table Date: Mon, 09 Mar 2026 08:09:01 +1000 Message-ID: In-Reply-To: <20260307-sahara_protocol_new_v2-v2-5-29dc748b5e9c@oss.qualcomm.com> References: <20260307-sahara_protocol_new_v2-v2-0-29dc748b5e9c@oss.qualcomm.com> <20260307-sahara_protocol_new_v2-v2-5-29dc748b5e9c@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review - **"SAHARA" channel matches QDU100 only** -- the variant entry uses `match= =3D "SAHARA"` and `match_is_chan =3D true`, meaning any device that expose= s a "SAHARA" channel will get the QDU100 image table. If other future devic= es also use "SAHARA" as their channel name, they'll incorrectly get QDU100'= s image table. The variant mechanism might need a secondary discriminator (= e.g., PCI device ID or controller name) for robustness. - **Commit message typo:** "The QDU100 device expose" =E2=86=92 "The QDU100= device exposes". --- Generated by Claude Code Patch Reviewer