From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: bus: mhi: Add QDU100 variant and image_id firmware fallback
Date: Wed, 11 Mar 2026 13:35:23 +1000
Message-ID: <review-patch5-20260310-sahara_protocol_new_v2-v3-5-994ea4b0d5ad@oss.qualcomm.com>
In-Reply-To: <20260310-sahara_protocol_new_v2-v3-5-994ea4b0d5ad@oss.qualcomm.com>
References: <20260310-sahara_protocol_new_v2-v3-0-994ea4b0d5ad@oss.qualcomm.com> <20260310-sahara_protocol_new_v2-v3-5-994ea4b0d5ad@oss.qualcomm.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

Adds the QDU100 image table and a generic `image_<id>.elf` firmware fallbac=
k.

**Issues:**
- **`SAHARA` channel matches QDU100 =E2=80=94 but is it really 1:1?** The v=
ariant entry uses `match =3D "SAHARA"` and `match_is_chan =3D true`, meanin=
g *any* device that binds on the SAHARA channel will get the QDU100 image t=
able and fw_folder. If another device type uses the SAHARA channel in the f=
uture, it will incorrectly get QDU100 firmware paths. The cover letter ackn=
owledges this design but it's fragile.

- The fallback path constructs `qcom/<folder>/image_<id>.elf`, but the QDU1=
00 table entries use `.mbn`, `.elf`, and `.bin` suffixes. The fallback alwa=
ys uses `.elf`, which may not match the actual firmware file extension for =
all image types.

- `sahara_request_fw` prints a `dev_dbg` on failure, and then `sahara_find_=
image` prints a `dev_err` for the same failure. The double logging is a bit=
 noisy.

---
Generated by Claude Code Patch Reviewer