From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: add support for pixel 3a xl with the tianma panel
Date: Tue, 10 Mar 2026 11:42:23 +1000 [thread overview]
Message-ID: <review-patch5-20260310002606.16413-6-mailingradian@gmail.com> (raw)
In-Reply-To: <20260310002606.16413-6-mailingradian@gmail.com>
Patch Review
**Status: Looks good.**
Clean device tree for the Pixel 3a XL Tianma variant. It includes the common dtsi and sets:
- `compatible = "google,bonito-tianma", "google,bonito", "qcom,sdm670"` — matches the binding from patch 1
- `charge-full-design-microamp-hours = <3700000>` — different battery from sargo (3000 vs 3700 mAh)
- `height = <2160>` — different panel resolution from sargo (2220 vs 2160)
- `compatible = "novatek,nt37700f"` — the Tianma panel
- Touchscreen dimensions matching the larger display
Already has Konrad's Reviewed-by. No issues.
**Summary of actionable items:**
1. **(Patch 2)** Clarify whether `panel-simple-dsi.yaml` is the correct place for the binding, given the dedicated driver in patch 3.
2. **(Patch 3)** Fix the error path in `nt37700f_tianma_prepare()` to disable the regulator on init failure.
3. **(Patch 3, minor)** Consider removing `MIPI_DSI_MODE_VIDEO_BURST` flag if this is a command-mode panel.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-10 1:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 0:26 [PATCH v3 0/5] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-03-10 0:26 ` [PATCH v3 1/5] dt-bindings: arm: qcom: document google, bonito-tianma board Richard Acayan
2026-03-10 1:42 ` Claude review: " Claude Code Review Bot
2026-03-10 0:26 ` [PATCH v3 2/5] dt-bindings: panel-simple-dsi: add nt37700f compatible Richard Acayan
2026-03-10 1:42 ` Claude review: " Claude Code Review Bot
2026-03-10 0:26 ` [PATCH v3 3/5] drm/panel: Add Novatek/Tianma NT37700F panel Richard Acayan
2026-03-10 1:42 ` Claude review: " Claude Code Review Bot
2026-03-10 0:26 ` [PATCH v3 4/5] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-03-10 1:42 ` Claude review: " Claude Code Review Bot
2026-03-10 0:26 ` [PATCH v3 5/5] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-03-10 1:42 ` Claude Code Review Bot [this message]
2026-03-10 1:42 ` Claude review: Support for the Pixel 3a XL with the Tianma panel Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-02-17 0:08 [PATCH v2 0/6] " Richard Acayan
2026-02-17 0:08 ` [PATCH v2 6/6] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-10 2:32 [PATCH 0/6] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-02-10 2:33 ` [PATCH 6/6] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-02-11 6:47 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260310002606.16413-6-mailingradian@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox