From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Date: Tue, 10 Mar 2026 11:42:23 +1000 Message-ID: In-Reply-To: <20260310002606.16413-6-mailingradian@gmail.com> References: <20260310002606.16413-1-mailingradian@gmail.com> <20260310002606.16413-6-mailingradian@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good.** Clean device tree for the Pixel 3a XL Tianma variant. It includes the commo= n dtsi and sets: - `compatible =3D "google,bonito-tianma", "google,bonito", "qcom,sdm670"` = =E2=80=94 matches the binding from patch 1 - `charge-full-design-microamp-hours =3D <3700000>` =E2=80=94 different bat= tery from sargo (3000 vs 3700 mAh) - `height =3D <2160>` =E2=80=94 different panel resolution from sargo (2220= vs 2160) - `compatible =3D "novatek,nt37700f"` =E2=80=94 the Tianma panel - Touchscreen dimensions matching the larger display Already has Konrad's Reviewed-by. No issues. **Summary of actionable items:** 1. **(Patch 2)** Clarify whether `panel-simple-dsi.yaml` is the correct pla= ce for the binding, given the dedicated driver in patch 3. 2. **(Patch 3)** Fix the error path in `nt37700f_tianma_prepare()` to disab= le the regulator on init failure. 3. **(Patch 3, minor)** Consider removing `MIPI_DSI_MODE_VIDEO_BURST` flag = if this is a command-mode panel. --- Generated by Claude Code Patch Reviewer