From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP Date: Thu, 12 Mar 2026 06:55:28 +1000 Message-ID: In-Reply-To: <20260311113611.3393194-6-ankit.k.nautiyal@intel.com> References: <20260311113611.3393194-1-ankit.k.nautiyal@intel.com> <20260311113611.3393194-6-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Fixes the bit-shift bug in `intel_dp_as_sdp_unpack()`: ```c - as_sdp->target_rr = (u64)sdp->db[3] | ((u64)sdp->db[4] & 0x3); + as_sdp->target_rr = ((sdp->db[4] & 0x3) << 8) | sdp->db[3]; ``` The old code OR'd DB[4] bits 1:0 into bits 1:0 of the result, overwriting DB[3] bits. Correct fix. Has Ville's R-b. Should have `Cc: stable`. --- Generated by Claude Code Patch Reviewer