From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/habanalabs: Use trace_invoke_##name() at guarded tracepoint call sites Date: Fri, 13 Mar 2026 14:04:53 +1000 Message-ID: In-Reply-To: <20260312150523.2054552-6-vineeth@bitbyteword.org> References: <1e3c2830-765e-4271-89f7-0b6784b37597@efficios.com> <20260312150523.2054552-6-vineeth@bitbyteword.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Mechanical conversion of 7 call sites across 3 files. All conversions look = correct: - `device.c:132-133` =E2=80=94 guarded by `trace_habanalabs_dma_alloc_enabl= ed()` =E2=9C=93 - `device.c:141-142` =E2=80=94 guarded by `trace_habanalabs_dma_map_page_en= abled()` (early return on line 205 of upstream) =E2=9C=93 - `device.c:150-151` =E2=80=94 guarded by `trace_habanalabs_dma_unmap_page_= enabled()` =E2=9C=93 - `device.c:159-160` =E2=80=94 guarded by `trace_habanalabs_rreg32_enabled(= )` =E2=9C=93 - `device.c:167-168` =E2=80=94 guarded by `trace_habanalabs_wreg32_enabled(= )` =E2=9C=93 - `mmu.c:181-183` =E2=80=94 guarded by `trace_habanalabs_mmu_unmap_enabled(= )` =E2=9C=93 - `pci.c:195-196` and `pci.c:204-205` =E2=80=94 guarded by `trace_habanalab= s_elbi_read_enabled()` and `trace_habanalabs_elbi_write_enabled()` respecti= vely =E2=9C=93 No issues with this patch. --- Generated by Claude Code Patch Reviewer