public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ttm: Be more aggressive when allocating below protection limit
Date: Sat, 14 Mar 2026 07:10:16 +1000	[thread overview]
Message-ID: <review-patch5-20260313-dmemcg-aggressive-protect-v6-5-7c71cc1492db@gmx.de> (raw)
In-Reply-To: <20260313-dmemcg-aggressive-protect-v6-5-7c71cc1492db@gmx.de>

Patch Review

This is the core behavioral change. When an allocation is protected by min/low and resource allocation fails, TTM now attempts eviction of unprotected buffers.

**Logic flow**:
```c
if (!alloc_state->in_evict) {
    may_evict |= dmem_cgroup_below_min(NULL, alloc_state->charge_pool);
    alloc_state->may_try_low = may_evict;
    may_evict |= dmem_cgroup_below_low(NULL, alloc_state->charge_pool);
}
```

This is subtly clever:
- If below **min**: `may_evict=true`, `may_try_low=true` (can try evicting low-protected BOs too)
- If below **low** (but not min): `may_evict=true`, `may_try_low=false` (only evict unprotected BOs)
- If neither: no change to `may_evict`, no aggressive eviction

The `may_try_low` flag gates the "retry with low" logic in `ttm_bo_evict_alloc()`, preventing low-but-not-min protected allocations from evicting low-protected buffers. This correctly models the min > low priority.

**Comment style**: The block comment at line 2133 starts with `/* If we failed...` — kernel style prefers the opening `/*` on its own line for multi-line comments. Minor style nit.

**The `may_try_low` field naming** could be slightly confusing since setting it to `true` means "yes, we may try evicting low-protected BOs" but the semantics in `ttm_bo_evict_alloc` are "skip the low retry if may_try_low is false". This is consistent but requires careful reading.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-13 21:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 11:39 [PATCH v6 0/6] cgroup/dmem,drm/ttm: Improve protection in contended cases Natalie Vock
2026-03-13 11:40 ` [PATCH v6 1/6] cgroup/dmem: Add queries for protection values Natalie Vock
2026-03-13 21:10   ` Claude review: " Claude Code Review Bot
2026-03-13 11:40 ` [PATCH v6 2/6] cgroup,cgroup/dmem: Add (dmem_)cgroup_common_ancestor helper Natalie Vock
2026-03-13 14:16   ` Michal Koutný
2026-03-13 21:10   ` Claude review: " Claude Code Review Bot
2026-03-13 11:40 ` [PATCH v6 3/6] drm/ttm: Extract code for attempting allocation in a place Natalie Vock
2026-03-13 21:10   ` Claude review: " Claude Code Review Bot
2026-03-13 11:40 ` [PATCH v6 4/6] drm/ttm: Split cgroup charge and resource allocation Natalie Vock
2026-03-13 12:53   ` Tvrtko Ursulin
2026-03-13 21:10   ` Claude review: " Claude Code Review Bot
2026-03-13 11:40 ` [PATCH v6 5/6] drm/ttm: Be more aggressive when allocating below protection limit Natalie Vock
2026-03-13 13:29   ` Tvrtko Ursulin
2026-03-13 21:10   ` Claude Code Review Bot [this message]
2026-03-13 11:40 ` [PATCH v6 6/6] drm/ttm: Use common ancestor of evictor and evictee as limit pool Natalie Vock
2026-03-13 14:11   ` Tvrtko Ursulin
2026-03-13 14:16   ` Michal Koutný
2026-03-13 21:10   ` Claude review: " Claude Code Review Bot
2026-03-13 21:10 ` Claude review: cgroup/dmem,drm/ttm: Improve protection in contended cases Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-02 12:37 [PATCH v5 0/6] " Natalie Vock
2026-03-02 12:37 ` [PATCH v5 5/6] drm/ttm: Be more aggressive when allocating below protection limit Natalie Vock
2026-03-03  3:29   ` Claude review: " Claude Code Review Bot
2026-02-25 12:10 [PATCH v4 0/6] cgroup/dmem,drm/ttm: Improve protection in contended cases Natalie Vock
2026-02-25 12:10 ` [PATCH v4 5/6] drm/ttm: Be more aggressive when allocating below protection limit Natalie Vock
2026-02-27  3:36   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260313-dmemcg-aggressive-protect-v6-5-7c71cc1492db@gmx.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox