From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: glymur-crd: Enable ADSP and CDSP Date: Sat, 14 Mar 2026 07:07:32 +1000 Message-ID: In-Reply-To: <20260313120814.1312410-6-sibi.sankar@oss.qualcomm.com> References: <20260313120814.1312410-1-sibi.sankar@oss.qualcomm.com> <20260313120814.1312410-6-sibi.sankar@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Simple board-level enablement: ```dts &remoteproc_adsp { firmware-name = "qcom/glymur/adsp.mbn", "qcom/glymur/adsp_dtb.mbn"; status = "okay"; }; &remoteproc_cdsp { firmware-name = "qcom/glymur/cdsp.mbn", "qcom/glymur/cdsp_dtb.mbn"; status = "okay"; }; ``` Firmware paths follow the standard `qcom//.mbn` convention. The firmware-name property with two entries (core firmware + DTB firmware) matches the binding's `string-array` definition. Both nodes are properly enabled with `status = "okay"`. No issues. Reviewed-by from both Abel Vesa and Konrad Dybcio. --- Generated by Claude Code Patch Reviewer