From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gpuvm: Add a flags field to drm_gpuva_op_map Date: Sat, 14 Mar 2026 06:48:45 +1000 Message-ID: In-Reply-To: <20260313150956.1618635-6-adrian.larumbe@collabora.com> References: <20260313150956.1618635-1-adrian.larumbe@collabora.com> <20260313150956.1618635-6-adrian.larumbe@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The `flags` field is added to `drm_gpuva_op_map` and propagated through all remap/unmap split paths. The `VA_MERGE_MUST_MATCH_FLAGS` mask approach is reasonable. **Dead callback declaration:** The `sm_can_merge_flags` callback is added to `struct drm_gpuvm_ops` but is never referenced or called anywhere in this series. It should either be used in `can_merge()` or removed: ```c + bool (*sm_can_merge_flags)(enum drm_gpuva_flags a, enum drm_gpuva_flags b); ``` This adds dead code to the UAPI-adjacent header and API surface with no implementation. --- Generated by Claude Code Patch Reviewer