From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: msm8953-flipkart-rimob: Enable touchscreen Date: Sun, 22 Mar 2026 05:00:33 +1000 Message-ID: In-Reply-To: <20260318-rimob-new-features-v2-5-c1bf8917449e@protonmail.com> References: <20260318-rimob-new-features-v2-0-c1bf8917449e@protonmail.com> <20260318-rimob-new-features-v2-5-c1bf8917449e@protonmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Enables a Goodix GT5688 touchscreen on I2C3. **Minor: `irq-gpios` may be redundant with `interrupts-extended`** ```dts interrupts-extended = <&tlmm 65 IRQ_TYPE_LEVEL_LOW>; irq-gpios = <&tlmm 65 GPIO_ACTIVE_HIGH>; ``` The Goodix binding allows both, and some drivers use `irq-gpios` for GPIO direction configuration during firmware loading. This is likely intentional and correct for the Goodix driver. No other issues. --- Generated by Claude Code Patch Reviewer