From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: bus: mhi: Add QDU100 variant and image_id firmware fallback Date: Sun, 22 Mar 2026 04:44:34 +1000 Message-ID: In-Reply-To: <20260319-sahara_protocol_new_v2-v4-5-47ad79308762@oss.qualcomm.com> References: <20260319-sahara_protocol_new_v2-v4-0-47ad79308762@oss.qualcomm.com> <20260319-sahara_protocol_new_v2-v4-5-47ad79308762@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds QDU100 image table and a fallback path for unknown image IDs. **Issues:** - **Channel "SAHARA" is hardcoded to QDU100 firmware**. Any future non-QDU100 device using the SAHARA MHI channel will incorrectly get QDU100 firmware. The design conflates transport channel name with device identity. - **Inconsistent format specifier**: `image_id` is `u32` but the fallback error message at `sahara.c:515` uses `%d` instead of `%u`: ```c "request for unknown image: %d\n", image_id ``` - **Double debug logging on firmware request failure**: `sahara_request_fw()` logs its own `dev_dbg`, then the caller logs another `dev_dbg`. Both fire on every failure. --- Generated by Claude Code Patch Reviewer