From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/exynos: exynos_dp: Apply of-display-mode-bridge to parse the display-timings node Date: Sun, 22 Mar 2026 04:35:46 +1000 Message-ID: In-Reply-To: <20260319071452.1961274-6-damon.ding@rock-chips.com> References: <20260319071452.1961274-1-damon.ding@rock-chips.com> <20260319071452.1961274-6-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This replaces the hand-rolled `exynos_dp_get_modes()` and `exynos_dp_dt_par= se_panel()` with the new `devm_drm_of_display_mode_bridge()`, which is clea= ner. The `has_of_bridge` flag is introduced temporarily to control whether = `DRM_BRIDGE_ATTACH_NO_CONNECTOR` is passed =E2=80=94 this is removed in pat= ch 11. One observation: the new code in `exynos_dp_probe()` at line 1347-1353 has = slightly awkward error handling: ```c ret =3D IS_ERR(dp->plat_data.next_bridge) ? PTR_ERR(dp->plat_data.next_brid= ge) : 0; ``` This works but is a bit unusual. The code in patch 14 simplifies this to th= e more idiomatic `if (IS_ERR(...)) return PTR_ERR(...)` pattern, so this is= cleaned up later. No blocking issues. --- Generated by Claude Code Patch Reviewer