From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: rockchip: analogix-dp: Add support for RK3576 Date: Sun, 22 Mar 2026 04:26:15 +1000 Message-ID: In-Reply-To: <20260319104031.1986946-6-damon.ding@rock-chips.com> References: <20260319104031.1986946-1-damon.ding@rock-chips.com> <20260319104031.1986946-6-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review ```yaml + - rockchip,rk3576-edp ``` Adding `rockchip,rk3576-edp` to the compatible enum and to the `if`/`then` = block that requires 2 resets is correct. Minor: The cover letter says "The eDP TX controller on RK3576 is the same a= s that on RK3588" =E2=80=94 if that's the case, consider whether a fallback= compatible like `compatible =3D "rockchip,rk3576-edp", "rockchip,rk3588-ed= p"` would be appropriate (documented in the binding). This is a DT best pra= ctice for SoCs sharing the same IP block, though it requires driver coopera= tion. --- Generated by Claude Code Patch Reviewer