From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: dw-hdmi: warn on unsupported attach combination
Date: Sun, 22 Mar 2026 03:48:38 +1000
Message-ID: <review-patch5-20260320-drm-lcdif-dbanc-v1-5-479a04133e70@bootlin.com>
In-Reply-To: <20260320-drm-lcdif-dbanc-v1-5-479a04133e70@bootlin.com>
References: <20260320-drm-lcdif-dbanc-v1-0-479a04133e70@bootlin.com> <20260320-drm-lcdif-dbanc-v1-5-479a04133e70@bootlin.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

The WARN_ON + early return is appropriate:

```c
if (WARN_ON((flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) && !hdmi->plat_data->o=
utput_port))
    return -EINVAL;
```

The commit message has a typo: "teh" should be "the".

The note about functional behavior is correct =E2=80=94 in the current code=
, if `DRM_BRIDGE_ATTACH_NO_CONNECTOR` is set and `output_port` is 0, `next_=
bridge` would be NULL, so `drm_bridge_attach()` would fail with `-EINVAL` a=
nyway.

---
Generated by Claude Code Patch Reviewer