public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dsi: Add support for RGB101010 pixel format
Date: Sun, 22 Mar 2026 03:12:29 +1000	[thread overview]
Message-ID: <review-patch5-20260321-dsi-rgb101010-support-v4-5-eb28ecebbfe8@pm.me> (raw)
In-Reply-To: <20260321-dsi-rgb101010-support-v4-5-eb28ecebbfe8@pm.me>

Patch Review

The format mappings are added to both vid and cmd mode:
```c
case MIPI_DSI_FMT_RGB101010:	return VID_DST_FORMAT_RGB101010;
...
case MIPI_DSI_FMT_RGB101010:	return CMD_DST_FORMAT_RGB101010;
```

The VID_CFG0 DST_FORMAT bitfield is extended from 2 bits to 3 bits:
```xml
<!-- high was 5 before DSI 6G 2.1.0 -->
<bitfield name="DST_FORMAT" low="4" high="6" type="dsi_vid_dst_format"/>
```

This is necessary since value 4 (`VID_DST_FORMAT_RGB101010`) requires 3 bits. The comment documenting the hardware version dependency is helpful.

The version guard in `dsi_host_attach`:
```c
if (dsi->format == MIPI_DSI_FMT_RGB101010 &&
    !msm_dsi_host_version_geq(msm_host, MSM_DSI_VER_MAJOR_6G,
			       MSM_DSI_6G_VER_MINOR_V2_1_0)) {
```

This correctly gates RGB101010 to v2.1.0+ controllers. Writing bit 6 of DST_FORMAT on older hardware (where that bit belongs to a different field or is reserved) could cause undefined behavior, so the guard is important.

**One minor concern:** The 3-bit DST_FORMAT bitfield is unconditionally defined in the XML register description. On pre-v2.1.0 hardware, bit 6 may overlap with another field. The XML comment notes this, but the generated header will always use the 3-bit definition regardless of hardware version. Since the format guard in `dsi_host_attach` prevents actually writing value 4 on old hardware, this is safe in practice, but it does mean the register description is technically inaccurate for older hardware revisions.

**No blocking issues.**

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-21 17:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-21  7:52 [PATCH v4 0/5] drm/msm: add RGB101010 pixel format and fix 10-bit DSC timing Alexander Koskovich
2026-03-21  7:52 ` [PATCH v4 1/5] drm/mipi-dsi: add RGB101010 pixel format Alexander Koskovich
2026-03-21 17:12   ` Claude review: " Claude Code Review Bot
2026-03-21  7:52 ` [PATCH v4 2/5] drm/meson: handle RGB101010 in format switches Alexander Koskovich
2026-03-21  9:37   ` Neil Armstrong
2026-03-21 17:12   ` Claude review: " Claude Code Review Bot
2026-03-21  7:52 ` [PATCH v4 3/5] drm/msm/dsi: rename MSM8998 DSI version from V2_2_0 to V2_0_0 Alexander Koskovich
2026-03-21 17:12   ` Claude review: " Claude Code Review Bot
2026-03-21  7:52 ` [PATCH v4 4/5] drm/msm/dsi: add DSI version >= comparison helper Alexander Koskovich
2026-03-21 17:12   ` Claude review: " Claude Code Review Bot
2026-03-21  7:52 ` [PATCH v4 5/5] drm/msm/dsi: Add support for RGB101010 pixel format Alexander Koskovich
2026-03-21 17:12   ` Claude Code Review Bot [this message]
2026-03-21 17:12 ` Claude review: drm/msm: add RGB101010 pixel format and fix 10-bit DSC timing Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-19 11:57 [PATCH v3 0/4] " Alexander Koskovich
2026-03-19 11:57 ` [PATCH v3 3/4] drm/msm/dsi: Add support for RGB101010 pixel format Alexander Koskovich
2026-03-21 18:21   ` Claude review: " Claude Code Review Bot
2026-03-19  3:59 [PATCH v2 0/3] drm/msm: add RGB101010 pixel format and fix 10-bit DSC timing Alexander Koskovich
2026-03-19  4:00 ` [PATCH v2 2/3] drm/msm/dsi: Add support for RGB101010 pixel format Alexander Koskovich
2026-03-21 18:52   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260321-dsi-rgb101010-support-v4-5-eb28ecebbfe8@pm.me \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox