From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/habanalabs: Use trace_call__##name() at guarded tracepoint call sites Date: Wed, 25 Mar 2026 07:48:30 +1000 Message-ID: In-Reply-To: <20260323160052.17528-6-vineeth@bitbyteword.org> References: <20260323160052.17528-1-vineeth@bitbyteword.org> <20260323160052.17528-6-vineeth@bitbyteword.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review All conversions are correct. Each `trace_call__` replacement is properly guarded by the corresponding `trace_*_enabled()` check. Examples: ```c if (trace_habanalabs_dma_alloc_enabled() && !ZERO_OR_NULL_PTR(ptr)) trace_call__habanalabs_dma_alloc(...) ``` ```c if (unlikely(trace_habanalabs_rreg32_enabled())) trace_call__habanalabs_rreg32(...) ``` The alignment fixups in `device.c` (e.g. adjusting continuation-line indentation for the longer function name) look fine. No issues. --- Generated by Claude Code Patch Reviewer