From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vblank: Add some debugging trace events Date: Wed, 25 Mar 2026 07:22:02 +1000 Message-ID: In-Reply-To: <20260323202755.315929-6-sunpeng.li@amd.com> References: <20260323202755.315929-1-sunpeng.li@amd.com> <20260323202755.315929-6-sunpeng.li@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Reasonable debugging addition. A few observations: - The `drm_vblank_put` trace comment notes `refcount not sync'd using vbl_l= ock` =E2=80=94 good callout. The trace shows the refcount *before* the decr= ement, which is slightly misleading for a "put" event. Consider tracing aft= er the dec, or documenting that it shows the pre-decrement value. - The trace events in `drm_vblank_get` are placed *after* acquiring `vbl_lo= ck` but *before* the `atomic_add_return`, so they show pre-increment refcou= nt, which is correct for showing the state at entry. - Style nit: some `if/else` blocks now have braces on one arm but not the o= ther (e.g., lines around `vblank_offdelay < 0`). The kernel style guide say= s if one branch has braces, both should. --- Generated by Claude Code Patch Reviewer