From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic-helper: Add HDMI bridge output bus formats helper Date: Wed, 25 Mar 2026 06:44:27 +1000 Message-ID: In-Reply-To: <20260324-color-format-v11-5-605559af4fb4@collabora.com> References: <20260324-color-format-v11-0-605559af4fb4@collabora.com> <20260324-color-format-v11-5-605559af4fb4@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The `drm_atomic_helper_bridge_get_hdmi_output_bus_fmts()` implementation is= clean. 1. **Typo in kerneldoc:** `"bits per compoennt"` should be `"bits per compo= nent"`. 2. **`BUILD_BUG_ON(const_true(DRM_OUTPUT_COLOR_FORMAT_COUNT > 8))`** =E2=80= =94 clever guard to ensure `hweight8` remains sufficient. Good. 3. The function doesn't validate `conn_state->hdmi.output_bpc` =E2=80=94 va= lues other than 8, 10, 12 fall through to the `default:` case which uses 8-= bit formats. This is fine since the HDMI state helper constrains BPC before= this point. --- Generated by Claude Code Patch Reviewer