public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: prevent encoder chain changes while iterating with list_for_each_entry_from()
Date: Wed, 25 Mar 2026 06:59:31 +1000	[thread overview]
Message-ID: <review-patch5-20260324-drm-bridge-alloc-encoder-chain-mutex-v5-5-8bf786c5c7e6@bootlin.com> (raw)
In-Reply-To: <20260324-drm-bridge-alloc-encoder-chain-mutex-v5-5-8bf786c5c7e6@bootlin.com>

Patch Review

Clean conversion of three functions to use `drm_for_each_bridge_in_chain_from()`. The parameter rename from `bridge` to `first_bridge` is appropriate.

In `drm_bridge_chain_mode_valid()`, the `return ret` inside the `drm_for_each_bridge_in_chain_from()` loop will correctly trigger the `__free` cleanup, unlocking the mutex and putting the bridge. Correct.

In `drm_bridge_chain_mode_set()` and `drm_atomic_bridge_chain_enable()`, the loop bodies don't use braces around multi-statement `if/else if` blocks — but that's consistent with the existing kernel style for these functions and technically correct since `drm_for_each_bridge_in_chain_from` expands to a `for` statement.

No issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-24 20:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24  8:58 [PATCH v5 0/7] drm/bridge: protect encoder bridge chain with a mutex Luca Ceresoli
2026-03-24  8:58 ` [PATCH v5 1/7] drm/encoder: add mutex to protect the bridge chain Luca Ceresoli
2026-03-24 20:59   ` Claude review: " Claude Code Review Bot
2026-03-24  8:58 ` [PATCH v5 2/7] drm/encoder: drm_encoder_cleanup: lock the encoder chain mutex during removal Luca Ceresoli
2026-03-24 20:59   ` Claude review: " Claude Code Review Bot
2026-03-24  8:58 ` [PATCH v5 3/7] drm/bridge: drm_bridge_attach: lock the encoder chain mutex during insertion Luca Ceresoli
2026-03-24 20:59   ` Claude review: " Claude Code Review Bot
2026-03-24  8:58 ` [PATCH v5 4/7] drm/bridge: lock the encoder chain in scoped for_each loops Luca Ceresoli
2026-03-24 20:59   ` Claude review: " Claude Code Review Bot
2026-03-24  8:58 ` [PATCH v5 5/7] drm/bridge: prevent encoder chain changes while iterating with list_for_each_entry_from() Luca Ceresoli
2026-03-24 20:59   ` Claude Code Review Bot [this message]
2026-03-24  8:58 ` [PATCH v5 6/7] drm/bridge: prevent encoder chain changes while iterating with list_for_each_entry_reverse() Luca Ceresoli
2026-03-24 20:59   ` Claude review: " Claude Code Review Bot
2026-03-24  8:58 ` [PATCH v5 7/7] drm/bridge: prevent encoder chain changes in pre_enable/post_disable Luca Ceresoli
2026-03-24 20:59   ` Claude review: " Claude Code Review Bot
2026-03-24 20:59 ` Claude review: drm/bridge: protect encoder bridge chain with a mutex Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260324-drm-bridge-alloc-encoder-chain-mutex-v5-5-8bf786c5c7e6@bootlin.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox