From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: prevent encoder chain changes while iterating with list_for_each_entry_from() Date: Wed, 25 Mar 2026 06:59:31 +1000 Message-ID: In-Reply-To: <20260324-drm-bridge-alloc-encoder-chain-mutex-v5-5-8bf786c5c7e6@bootlin.com> References: <20260324-drm-bridge-alloc-encoder-chain-mutex-v5-0-8bf786c5c7e6@bootlin.com> <20260324-drm-bridge-alloc-encoder-chain-mutex-v5-5-8bf786c5c7e6@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Clean conversion of three functions to use `drm_for_each_bridge_in_chain_fr= om()`. The parameter rename from `bridge` to `first_bridge` is appropriate. In `drm_bridge_chain_mode_valid()`, the `return ret` inside the `drm_for_ea= ch_bridge_in_chain_from()` loop will correctly trigger the `__free` cleanup= , unlocking the mutex and putting the bridge. Correct. In `drm_bridge_chain_mode_set()` and `drm_atomic_bridge_chain_enable()`, th= e loop bodies don't use braces around multi-statement `if/else if` blocks = =E2=80=94 but that's consistent with the existing kernel style for these fu= nctions and technically correct since `drm_for_each_bridge_in_chain_from` e= xpands to a `for` statement. No issues. --- Generated by Claude Code Patch Reviewer