From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP Date: Tue, 31 Mar 2026 17:39:46 +1000 Message-ID: In-Reply-To: <20260330040656.4116502-6-ankit.k.nautiyal@intel.com> References: <20260330040656.4116502-1-ankit.k.nautiyal@intel.com> <20260330040656.4116502-6-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Correct fix =E2=80=94 the original code `(u64)sdp->db[3] | ((u64)sdp->db[4]= & 0x3)` ORs the two bytes without shifting, producing wrong values. The fi= x properly shifts DB4 bits up: ```c + as_sdp->target_rr =3D ((sdp->db[4] & 0x3) << 8) | sdp->db[3]; ``` Has Fixes: tag and Ville's R-b. Good. --- Generated by Claude Code Patch Reviewer