From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/exec, drm/xe, drm/amdgpu: Add an accessor for struct drm_exec::ticket Date: Wed, 01 Apr 2026 07:52:58 +1000 Message-ID: In-Reply-To: <20260331092023.81616-6-thomas.hellstrom@linux.intel.com> References: <20260331092023.81616-1-thomas.hellstrom@linux.intel.com> <20260331092023.81616-6-thomas.hellstrom@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Bug: The amdkfd changes won't compile.** In `amdgpu_amdkfd_gpuvm.c`, `exec` is declared as `struct drm_exec exec;` (= a local struct, not a pointer). The patch changes: ```c - ret =3D process_validate_vms(process_info, &exec.ticket); + ret =3D process_validate_vms(process_info, drm_exec_ticket(exec)); ``` Since `drm_exec_ticket()` takes `struct drm_exec *`, this should be `drm_ex= ec_ticket(&exec)`. The same bug appears on both call sites at lines 976 and= 985 of the diff. This will cause a type mismatch compile error. The `amdgpu_cs.c` changes use `drm_exec_ticket(&p->exec)` which is correct = (taking address of a struct member). The `xe_validation.c` changes use `drm_exec_ticket(exec)` where `exec` is a= lready a `struct drm_exec *` parameter =E2=80=94 correct. The accessor itself is fine: ```c static inline struct ww_acquire_ctx *drm_exec_ticket(struct drm_exec *exec) { return &exec->ticket; } ``` **Summary for patch 5:** Fix the two `drm_exec_ticket(exec)` calls in `amdg= pu_amdkfd_gpuvm.c` to `drm_exec_ticket(&exec)`. --- Generated by Claude Code Patch Reviewer