From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: lib/fonts: Implement glyph rotation Date: Sun, 12 Apr 2026 13:55:02 +1000 Message-ID: In-Reply-To: <20260407092555.58816-6-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> <20260407092555.58816-6-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Correct code movement.** Moves `pattern_test_bit`, `pattern_set_bit`, `rotate_cw`, `rotate_ud`, `rotate_ccw` from `fbcon_rotate.h` (static inlines) into `lib/fonts/font_rotate.c`. Wraps them in public API functions (`font_glyph_rotate_90/180/270`) that add a `memset(out, 0, ...)` before calling the internal rotate. This is important since the `set_bit` functions only OR bits in. The commit message correctly notes that this trades one bulk `memset` (old code zeroed the entire font buffer) for per-glyph `memset` calls, but this will be optimized again in patch 8. The `EXPORT_SYMBOL_GPL` is appropriate since the callers are in a different module. The interface change placing `out` as the last parameter (matching kernel convention for output buffers) is a nice touch. No issues with the logic -- this is a pure code movement with no behavioral changes to the rotation algorithms themselves. --- --- Generated by Claude Code Patch Reviewer