From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/sysfb: vesadrm: Support power management Date: Sun, 12 Apr 2026 12:33:55 +1000 Message-ID: In-Reply-To: <20260408120722.328769-6-tzimmermann@suse.de> References: <20260408120722.328769-1-tzimmermann@suse.de> <20260408120722.328769-6-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Correct.** Same pattern as efidrm/ofdrm -- probe stores `dev`: ```c platform_set_drvdata(pdev, dev); /* vesadrm.c:438 */ ``` PM callbacks match. No issues. This is also the one Thomas notes was tested with qemu's bochs device. --- **Summary:** All five patches are correct and consistent with each driver's existing drvdata convention. The only potential improvement would be consolidating the identical PM logic into a shared helper, but that would require first unifying the drvdata convention across the five drivers. Reviewed-by can be given for the series as-is. --- Generated by Claude Code Patch Reviewer