From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tyr: Remove custom register struct
Date: Sun, 12 Apr 2026 10:45:09 +1000
Message-ID: <review-patch5-20260409-b4-tyr-use-register-macro-v5-v5-5-8abfff8a0204@collabora.com>
In-Reply-To: <20260409-b4-tyr-use-register-macro-v5-v5-5-8abfff8a0204@collabora.com>
References: <20260409-b4-tyr-use-register-macro-v5-v5-0-8abfff8a0204@collabora.com> <20260409-b4-tyr-use-register-macro-v5-v5-5-8abfff8a0204@collabora.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Clean removal of the now-unused `Register<OFFSET>` struct, its `read`/`write` methods, and associated imports. After patches 1, 3, and 4 converted all users, this is purely mechanical cleanup.

```rust
-pub(crate) struct Register<const OFFSET: usize>;
-impl<const OFFSET: usize> Register<OFFSET> {
-    pub(crate) fn read(...) -> Result<u32> { ... }
-    pub(crate) fn write(...) -> Result { ... }
-}
```

No issues. This is ordered correctly in the series -- all users are converted first, then the old infrastructure is removed.

---
Generated by Claude Code Patch Reviewer