From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/display: Switch to managed for crtc Date: Sun, 12 Apr 2026 10:51:25 +1000 Message-ID: In-Reply-To: <20260409-feat_link_cap-v1-5-7069e8199ce2@bootlin.com> References: <20260409-feat_link_cap-v1-0-7069e8199ce2@bootlin.com> <20260409-feat_link_cap-v1-5-7069e8199ce2@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The conversion from `intel_crtc_alloc()` + `drm_crtc_init_with_planes()` to `drmm_crtc_alloc_with_planes()` is structurally correct. The `drmm_add_action_or_reset()` for `cpu_latency_qos` cleanup is appropriate. Concern: the commit message is very thin ("It is not an issue yet, but in order to comply with the latest DRM requirement"). This is a substantial reordering of initialization (planes before CRTC) and removal of error paths. The commit message should explain *why* the reordering is safe and document which cleanup paths are now handled by devres vs. callbacks. --- Generated by Claude Code Patch Reviewer