From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/exynos: exynos_dp: Apply of-display-mode-bridge to parse the display-timings node Date: Sun, 12 Apr 2026 11:37:39 +1000 Message-ID: In-Reply-To: <20260409065301.446670-6-damon.ding@rock-chips.com> References: <20260409065301.446670-1-damon.ding@rock-chips.com> <20260409065301.446670-6-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Replaces the Exynos-specific `exynos_dp_get_modes()` / `exynos_dp_dt_parse_panel()` with the generic `devm_drm_of_display_mode_bridge()` helper from patch 2. This removes the `struct videomode vm` member and the manual `drm_display_mode_from_videomode()` flow. Introduces `dp->has_of_bridge` as a temporary flag (removed later in patch 11). The flag is used to conditionally set `DRM_BRIDGE_ATTACH_NO_CONNECTOR` only for the of-display-mode-bridge, since at this point the driver still creates its own connector for non-bridge paths. The transition logic is sound. One minor observation: the `dp->plat_data.get_modes` assignment is removed here, but the `get_modes` callback in analogix_dp_core still exists at this point (removed in patch 8). The Exynos `get_modes` just returned 0 for panel paths anyway, so this doesn't cause functional issues. No issues. --- Generated by Claude Code Patch Reviewer