From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: splite msm_dp_ctrl_config_ctrl() into link parts and stream parts Date: Sun, 12 Apr 2026 10:16:12 +1000 Message-ID: In-Reply-To: <20260410-msm-dp-mst-v4-5-b20518dea8de@oss.qualcomm.com> References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> <20260410-msm-dp-mst-v4-5-b20518dea8de@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Typo in subject**: "splite" should be "split". The split itself is correct =E2=80=94 link-level config (LSCLK div, ASSR, l= ane count, enhanced framing) goes to `msm_dp_ctrl_config_ctrl_link()`, and = stream-level config (YUV420 mode, BPC, VSC) goes to `msm_dp_ctrl_config_ctr= l_streams()`. This separation is needed for MST where multiple streams shar= e a single link configuration. One concern: `msm_dp_ctrl_config_ctrl_streams()` does a read-modify-write: ```c + config =3D msm_dp_read_link(ctrl, REG_DP_CONFIGURATION_CTRL); ``` This reads back what `_link()` just wrote, then ORs in stream bits. This wo= rks but means the two functions are order-dependent =E2=80=94 `_link()` mus= t always be called before `_streams()`. A comment would help. --- Generated by Claude Code Patch Reviewer