From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: dipslay/panel: describe panels using Focaltech OTA7290B Date: Sun, 12 Apr 2026 09:06:54 +1000 Message-ID: In-Reply-To: <20260411-waveshare-dsi-touch-v2-5-75cdbeac5156@oss.qualcomm.com> References: <20260411-waveshare-dsi-touch-v2-0-75cdbeac5156@oss.qualcomm.com> <20260411-waveshare-dsi-touch-v2-5-75cdbeac5156@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review New binding schema for `focaltech,ota7290b.yaml`. **Has multiple issues:** 1. **Subject line typo**: "dipslay" should be "display" 2. **Compatible string mismatch**: Schema says `const: waveshare,8.88-dsi-touch-a` but the example and driver (patch 19) use `waveshare,8.8-dsi-touch-a`. The schema `const` should be `8.8`, not `8.88`. 3. **Property/required mismatch**: Properties section defines `vcc-supply` but required section lists `vccio-supply`. With `additionalProperties: false`, this makes the schema internally contradictory -- `vccio-supply` is both required and forbidden. The example uses `vccio-supply`, so the properties section should define `vccio-supply` instead of `vcc-supply`. 4. **Supply name mismatch with driver**: The driver (patch 19) calls `devm_regulator_get_optional(&dsi->dev, "iovcc")` and `devm_regulator_get_optional(&dsi->dev, "avdd")`, meaning it expects DT properties `iovcc-supply` and `avdd-supply`. But the binding defines `vcc-supply`/`vccio-supply` and `vdda-supply`. These names must match between binding and driver. --- --- Generated by Claude Code Patch Reviewer