From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: soc: qcom: pmic-glink-altmode: pass down HPD_IRQ events Date: Thu, 23 Apr 2026 09:07:43 +1000 Message-ID: In-Reply-To: <20260421-hpd-irq-events-v3-5-44d2bf40dfc2@oss.qualcomm.com> References: <20260421-hpd-irq-events-v3-0-44d2bf40dfc2@oss.qualcomm.com> <20260421-hpd-irq-events-v3-5-44d2bf40dfc2@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean consumer change. The `alt_port->hpd_irq` field already exists and is populated from PMIC GLINK messages. This patch simply passes it through the bridge notification path: ```c drm_aux_hpd_bridge_notify_extra(&alt_port->bridge->dev, conn_status, alt_port->hpd_irq ? DRM_CONNECTOR_DP_IRQ_HPD : DRM_CONNECTOR_NO_EXTRA_STATUS); ``` Note that `pmic_glink_altmode_enable_dp()` on the lines above already receives `alt_port->hpd_irq` and handles the DP PHY configuration side. The bridge notification handles the display/connector side. No duplication issue. --- Generated by Claude Code Patch Reviewer