From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: io: restrict untyped IO access and `register!` to `Region`
Date: Thu, 23 Apr 2026 08:25:45 +1000
Message-ID: <review-patch5-20260421-io_projection-v2-5-4c251c692ef4@garyguo.net>
In-Reply-To: <20260421-io_projection-v2-5-4c251c692ef4@garyguo.net>
References: <20260421-io_projection-v2-0-4c251c692ef4@garyguo.net> <20260421-io_projection-v2-5-4c251c692ef4@garyguo.net>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Adds a `Base` type parameter to `IoLoc` so that untyped offset-based I/O (like `read32(0x10)`) only works on `Region`-typed I/O, not on typed I/O regions. This prevents nonsensical operations like `io.read8(1)` on an `Mmio<u32>`.

The `FIXME` comment is honest:
```rust
// FIXME: Make use of `Base` type parameter of `Region` directly.
```

The approach is reasonable and extensible to future register block typing. Implementation is mechanical but correct.

---
Generated by Claude Code Patch Reviewer