From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: Make tegra_fb_alloc() an internal interface
Date: Thu, 23 Apr 2026 08:46:59 +1000
Message-ID: <review-patch5-20260421073646.144712-6-tzimmermann@suse.de>
In-Reply-To: <20260421073646.144712-6-tzimmermann@suse.de>
References: <20260421073646.144712-1-tzimmermann@suse.de> <20260421073646.144712-6-tzimmermann@suse.de>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Status: Good**

Since fbdev.c no longer calls `tegra_fb_alloc()` directly (it goes through =
`drm_mode_addfb2` =E2=86=92 `tegra_fb_create` =E2=86=92 `tegra_fb_alloc` in=
ternally), the function can be made static. The declaration is removed from=
 `drm.h` and `static` is added in `fb.c`:

```c
+static
 struct drm_framebuffer *tegra_fb_alloc(struct drm_device *drm,
```

The only remaining caller is `tegra_fb_create()` in the same file. Straight=
forward cleanup.

No issues.

---
Generated by Claude Code Patch Reviewer