From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: atafb: Use safer strscpy() instead of strcpy()
Date: Tue, 28 Apr 2026 15:38:40 +1000
Message-ID: <review-patch5-20260425065926.1091168-6-aichao@kylinos.cn>
In-Reply-To: <20260425065926.1091168-6-aichao@kylinos.cn>
References: <20260425065926.1091168-1-aichao@kylinos.cn> <20260425065926.1091168-6-aichao@kylinos.cn>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Files:** `atafb.c` =E2=80=94 5 replacements

Four of the five changes are fine. String `"Unknown Extern"` is 15 bytes wi=
th NUL, which exactly fits `char id[16]` =E2=80=94 tight but correct.

**Issue: modifying commented-out code:**

```c
-//	strcpy(fb_info.mode->name, "Atari Builtin ");
+//	strscpy(fb_info.mode->name, "Atari Builtin ");
```

Changing dead (commented-out) code from `strcpy` to `strscpy` is pointless.=
 If the code is dead, either leave it alone or remove it entirely. This jus=
t creates unnecessary churn.

---

---
Generated by Claude Code Patch Reviewer