From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: refactor SEC2 booter loading into BooterFirmware::run()
Date: Tue, 28 Apr 2026 15:01:47 +1000
Message-ID: <review-patch5-20260427-nova-unload-v4-5-e145ccddae66@nvidia.com>
In-Reply-To: <20260427-nova-unload-v4-5-e145ccddae66@nvidia.com>
References: <20260427-nova-unload-v4-0-e145ccddae66@nvidia.com> <20260427-nova-unload-v4-5-e145ccddae66@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

This moves the SEC2 reset/load/boot sequence from inline code in `boot()` i=
nto `BooterFirmware::run()`. The refactoring also creates a `run_booter()` =
helper on `Gsp`.

One small difference between old and new code: the old code used `dev_dbg!(=
pdev, ...)` while the new `BooterFirmware::run()` uses `dev_dbg!(dev, ...)`=
. Both resolve to the same device, since `pdev.as_ref()` gives the device, =
but the log source device type differs slightly. This is cosmetic.

The `BooterFirmware::run()` takes a generic `wpr_meta: &Coherent<T>` =E2=80=
=94 this is good since it only needs the DMA handle, not the specific type.

The BooterFirmware construction is also separated from use =E2=80=94 previo=
usly it was constructed early and used late. Now with `run_booter()`, const=
ruction and execution are together. This is cleaner.

No issues.

---

---
Generated by Claude Code Patch Reviewer