From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Use a local iomem base for GPU registers Date: Tue, 28 Apr 2026 14:28:32 +1000 Message-ID: In-Reply-To: <20260427155934.416502-6-karunika.choo@arm.com> References: <20260427155934.416502-1-karunika.choo@arm.com> <20260427155934.416502-6-karunika.choo@arm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `gpu->iomem = ptdev->iomem + GPU_CONTROL_BASE` (where `GPU_CONTROL_BASE` is 0x0, so effectively the same pointer for now). Converts all GPU register accesses. The IRQ handler body switches to `gpu->irq.iomem` with generic offsets. The `GPU_INT_RAWSTAT` etc. absolute macros are removed since they're no longer needed. In `panthor_hw.c`, `panthor_gpu_info_init()` creates a local `gpu_iomem` pointer since `ptdev->gpu` may not yet be initialized at that point. This is the correct approach. No issues. --- Generated by Claude Code Patch Reviewer