From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Make panthor_fw_{update,toggle}_reqs() callable from IRQ context Date: Tue, 05 May 2026 11:44:53 +1000 Message-ID: In-Reply-To: <20260429-panthor-signal-from-irq-v1-5-4b92ae4142d2@collabora.com> References: <20260429-panthor-signal-from-irq-v1-0-4b92ae4142d2@collabora.com> <20260429-panthor-signal-from-irq-v1-5-4b92ae4142d2@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Looks good.** Converts `spin_lock/unlock` to `guard(spinlock_irqsave)` in the `panthor_fw_toggle_reqs`, `panthor_fw_update_reqs`, and `panthor_fw_update_reqs64` macros. This is necessary preparation for calling these from hard IRQ context in patch 9. --- --- Generated by Claude Code Patch Reviewer