From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe: Set TTM device beneficial_order to 9 (2M) Date: Tue, 05 May 2026 10:13:41 +1000 Message-ID: In-Reply-To: <20260430182335.2132382-6-matthew.brost@intel.com> References: <20260430182335.2132382-1-matthew.brost@intel.com> <20260430182335.2132382-6-matthew.brost@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Overall:** Simple one-liner that sets the beneficial order for Xe's TTM device to order 9 (2M pages). ```c - xe->drm.vma_offset_manager, 0); + xe->drm.vma_offset_manager, + TTM_ALLOCATION_POOL_BENEFICIAL_ORDER(get_order(SZ_2M))); ``` **Observations:** - `get_order(SZ_2M)` = `get_order(2*1024*1024)` = 9 on systems with 4K pages. On 16K page systems (some ARM), this would be different. Using `get_order()` is correct and portable. - `TTM_ALLOCATION_POOL_BENEFICIAL_ORDER` is a simple mask `((n) & 0xff)` so this is just `9 & 0xff = 9`. - Already has Reviewed-by from Andi Shyti. - Clean and correct. --- Generated by Claude Code Patch Reviewer