From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Fold poweron and setup functions Date: Tue, 05 May 2026 07:58:55 +1000 Message-ID: In-Reply-To: <20260504191059.275928-6-jonas@kwiboo.se> References: <20260504191059.275928-1-jonas@kwiboo.se> <20260504191059.275928-6-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Merges `dw_hdmi_poweron()` and `dw_hdmi_setup()` into a single function, an= d has `dw_hdmi_bridge_atomic_enable()` fetch the `adjusted_mode` directly f= rom the atomic state.=20 ```c + crtc =3D drm_atomic_get_new_connector_state(state, connector)->crtc; + mode =3D &drm_atomic_get_new_crtc_state(state, crtc)->adjusted_mode; ``` No NULL checks on the connector_state or crtc =E2=80=94 this is fine becaus= e `atomic_enable` is only called when the connector is actively being enabl= ed, so the connector state and CRTC must be valid. Has Reviewed-by. --- Generated by Claude Code Patch Reviewer