From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: PCI: tegra: Explicitly specify PMC instance to use
Date: Thu, 07 May 2026 13:29:35 +1000
Message-ID: <review-patch5-20260506-pmc-v1-5-a6de5da7216b@nvidia.com>
In-Reply-To: <20260506-pmc-v1-5-a6de5da7216b@nvidia.com>
References: <20260506-pmc-v1-0-a6de5da7216b@nvidia.com> <20260506-pmc-v1-5-a6de5da7216b@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Bug:** The error handling in `tegra_pcie_get_resources()` returns a stale `err`:

```c
	pcie->pmc = devm_tegra_pmc_get(dev);
	if (IS_ERR(pcie->pmc)) {
		dev_err_probe(dev, PTR_ERR(pcie->pmc), "failed to get PMC\n");
		return err;
	}
```

This should be `return PTR_ERR(pcie->pmc)`. The variable `err` at this point holds the return value of `tegra_pcie_resets_get()` from earlier, which was 0 (success) -- so on PMC lookup failure, this function would return 0, silently indicating success with `pcie->pmc` set to an error pointer. This will cause an oops the first time `pcie->pmc` is dereferenced in a powergate call.

This needs to be fixed to:
```c
	pcie->pmc = devm_tegra_pmc_get(dev);
	if (IS_ERR(pcie->pmc))
		return dev_err_probe(dev, PTR_ERR(pcie->pmc), "failed to get PMC\n");
```

or equivalently, assign `err = PTR_ERR(pcie->pmc)` before the `dev_err_probe` and return `err`.

---
Generated by Claude Code Patch Reviewer