From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Fold poweron and setup functions Date: Sat, 16 May 2026 16:21:42 +1000 Message-ID: In-Reply-To: <20260510124111.1226584-6-jonas@kwiboo.se> References: <20260510124111.1226584-1-jonas@kwiboo.se> <20260510124111.1226584-6-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Merges the old `dw_hdmi_poweron()` wrapper and `dw_hdmi_setup()` into a single `dw_hdmi_poweron(struct dw_hdmi *, const struct drm_connector *, const struct drm_display_mode *)`, and retrieves `adjusted_mode` from `crtc_state` in the caller: ```c + crtc = drm_atomic_get_new_connector_state(state, connector)->crtc; + mode = &drm_atomic_get_new_crtc_state(state, crtc)->adjusted_mode; ``` These calls are guaranteed to return non-NULL in the `atomic_enable` path since the connector/crtc are participating in the commit. This follows established kernel patterns. No issues. --- Generated by Claude Code Patch Reviewer