From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/exynos: Make exynos_drm_framebuffer_init() an internal interface
Date: Sat, 16 May 2026 15:38:05 +1000
Message-ID: <review-patch5-20260511115538.57884-6-tzimmermann@suse.de>
In-Reply-To: <20260511115538.57884-6-tzimmermann@suse.de>
References: <20260511115538.57884-1-tzimmermann@suse.de> <20260511115538.57884-6-tzimmermann@suse.de>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Status: Good**

After patch 4 removed the fbdev caller of `exynos_drm_framebuffer_init()`, =
the only remaining caller is `exynos_user_fb_create()` in the same file. Ma=
king it `static` is the right thing to do:

```c
-struct drm_framebuffer *
+static struct drm_framebuffer *
 exynos_drm_framebuffer_init(...)
```

The header cleanup is also correct =E2=80=94 replacing the `#include "exyno=
s_drm_gem.h"` (which was only needed for the now-removed declaration) with =
minimal forward declarations and `<linux/types.h>` for `dma_addr_t`:

```c
-#include "exynos_drm_gem.h"
+#include <linux/types.h>

-struct drm_framebuffer *
-exynos_drm_framebuffer_init(...);
+struct drm_device;
+struct drm_framebuffer;
```

The compensating `#include "exynos_drm_gem.h"` additions in `exynos_drm_fb.=
c` and `exynos_drm_fbdev.c` are correct =E2=80=94 both files use `exynos_dr=
m_gem` types and were previously getting the header transitively through `e=
xynos_drm_fb.h`.

No concerns.

---
Generated by Claude Code Patch Reviewer