From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Make panthor_fw_{update,toggle}_reqs() callable from IRQ context Date: Sat, 16 May 2026 13:32:45 +1000 Message-ID: In-Reply-To: <20260512-panthor-signal-from-irq-v2-5-95c614a739cb@collabora.com> References: <20260512-panthor-signal-from-irq-v2-0-95c614a739cb@collabora.com> <20260512-panthor-signal-from-irq-v2-5-95c614a739cb@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **R-b: Steven Price, Liviu Dudau** Converts `spin_lock`/`spin_unlock` to `guard(spinlock_irqsave)` in the three FW req macros (`panthor_fw_toggle_reqs`, `panthor_fw_update_reqs`, `panthor_fw_update_reqs64`). This is required because these macros are called from `sched_process_csg_irq_locked()` which will later be called from IRQ context. The `guard()` approach is clean and eliminates the need for explicit unlock. The `do { ... } while(0)` scope naturally provides the guard scope. No concerns. --- --- Generated by Claude Code Patch Reviewer