From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: renesas: rz-du: Add support for RZ/T2H SoC
Date: Sat, 16 May 2026 13:13:43 +1000
Message-ID: <review-patch5-20260512144104.761531-6-prabhakar.mahadev-lad.rj@bp.renesas.com>
In-Reply-To: <20260512144104.761531-6-prabhakar.mahadev-lad.rj@bp.renesas.com>
References: <20260512144104.761531-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20260512144104.761531-6-prabhakar.mahadev-lad.rj@bp.renesas.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Status: Looks good.**

This patch adds the device info, feature flag, and CRTC modification for RZ=
/T2H:

```c
+#define RZG2L_DU_FEATURE_DPIO_OE	BIT(0)	/* Has DPIO output enable control =
*/
```

```c
+static const struct rzg2l_du_device_info rzg2l_du_r9a09g077_info =3D {
+	.channels_mask =3D BIT(0),
+	.routes =3D {
+		[RZG2L_DU_OUTPUT_DPAD0] =3D {
+			.possible_outputs =3D BIT(0),
+			.port =3D 0,
+			.mode_clock_min =3D 5000,
+			.mode_clock_max =3D 100000,
+		},
+	},
+	.features =3D RZG2L_DU_FEATURE_DPIO_OE,
+};
```

The `rzg2l_du_has()` helper is clean:

```c
+static inline bool rzg2l_du_has(struct rzg2l_du_device *rcdu,
+				unsigned int feature)
+{
+	return rcdu->info->features & feature;
+}
```

The CRTC start/stop modification correctly gates DPI_EN on the feature flag:

```c
+	u32 val =3D DU_MCR0_DI_EN;
+
+	if (start && rzg2l_du_has(rcdu, RZG2L_DU_FEATURE_DPIO_OE))
+		val |=3D DU_MCR0_DPI_EN;
+
+	writel(start ? val : 0, rcdu->mmio + DU_MCR0);
```

The DPI_EN bit is only asserted during start and cleared on stop (val becom=
es 0). This is correct behavior =E2=80=94 the output enable should track th=
e display state.

The clock limits (5=E2=80=93100 MHz) differ from the RZ/G2UL limits (20.875=
=E2=80=9383.5 MHz), which validates the per-output routing design from patc=
h 4.

Has Reviewed-by from Laurent Pinchart.

**Summary:** The series is well-structured and mostly ready. The main point=
 to address is whether the `if/then/else` pattern for `resets` in the bindi=
ng (patch 2) follows the preferred DT schema style, or whether keeping `res=
ets` in the global `required` and only adding an `if/then` override for RZ/=
T2H would be cleaner. The driver changes are correct and well-designed.

---
Generated by Claude Code Patch Reviewer