From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: kunit: provide kunit_software_node_register() Date: Sat, 16 May 2026 11:52:20 +1000 Message-ID: In-Reply-To: <20260513-swnode-remove-on-dev-unreg-v6-5-f9c58939df27@oss.qualcomm.com> References: <20260513-swnode-remove-on-dev-unreg-v6-0-f9c58939df27@oss.qualcomm.com> <20260513-swnode-remove-on-dev-unreg-v6-5-f9c58939df27@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Clean helper.** Registers a software node and returns its fwnode handle, with kunit-managed cleanup via `kunit_add_action_or_reset()`. The WARN_ON for `!fwnode` after a successful `software_node_register()` is appropriate as a defensive check -- this should never happen but would indicate a serious kernel bug. The header and implementation are well-structured with proper SPDX and export. **Verdict**: No issues. --- --- Generated by Claude Code Patch Reviewer