public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu: hook up ZONE_DEVICE registration in device init and reset
Date: Sat, 16 May 2026 12:15:39 +1000	[thread overview]
Message-ID: <review-patch5-20260513095734.69598-6-Junhua.Shen@amd.com> (raw)
In-Reply-To: <20260513095734.69598-6-Junhua.Shen@amd.com>

Patch Review

**Unnecessary `#if IS_ENABLED` guards:**
```c
#if IS_ENABLED(CONFIG_DRM_AMDGPU_SVM)
	amdgpu_svm_migration_init(adev);
#endif
```
The header already provides a static inline stub returning 0 when `CONFIG_DRM_AMDGPU_SVM` is disabled. The `#if` guard is redundant and adds visual noise. Just call the function directly.

**Return value of `amdgpu_svm_migration_init` is ignored** in both callsites. If initialization fails (e.g., `devm_memremap_pages` fails), the device will continue without VRAM migration support. The cover letter says `adev->apagemap` is NULL when disabled, and the helper functions check for this, so this is likely intentional — but a `dev_warn` on failure would help debugging.

**In the reset path:**
```c
if (!tmp_adev->kfd.init_complete) {
#if IS_ENABLED(CONFIG_DRM_AMDGPU_SVM)
	amdgpu_svm_migration_init(tmp_adev);
#endif
	kgd2kfd_init_zone_device(tmp_adev);
```
`amdgpu_svm_migration_init` has an early-return check `if (adev->apagemap && adev->apagemap->initialized) return 0;` — so calling it again after reset is safe. Good.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  2:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13  9:57 [PATCH v4 0/6] drm/amdgpu: SVM VRAM migration via drm_pagemap (XNACK-on) Junhua Shen
2026-05-13  9:57 ` [PATCH v4 1/6] drm/amdgpu: add VRAM migration infrastructure for drm_pagemap Junhua Shen
2026-05-16  2:15   ` Claude review: " Claude Code Review Bot
2026-05-13  9:57 ` [PATCH v4 2/6] drm/amdgpu: implement drm_pagemap SDMA migration callbacks Junhua Shen
2026-05-16  2:15   ` Claude review: " Claude Code Review Bot
2026-05-13  9:57 ` [PATCH v4 3/6] drm/amdgpu: implement synchronous TTM eviction for SVM BOs Junhua Shen
2026-05-16  2:15   ` Claude review: " Claude Code Review Bot
2026-05-13  9:57 ` [PATCH v4 4/6] drm/amdgpu: add SVM range migration helpers for drm_pagemap Junhua Shen
2026-05-16  2:15   ` Claude review: " Claude Code Review Bot
2026-05-13  9:57 ` [PATCH v4 5/6] drm/amdgpu: hook up ZONE_DEVICE registration in device init and reset Junhua Shen
2026-05-13 13:47   ` Christian König
2026-05-14  7:33     ` Junhua Shen
2026-05-16  2:15   ` Claude Code Review Bot [this message]
2026-05-13  9:57 ` [PATCH v4 6/6] drm/amdgpu: integrate VRAM migration into SVM range map and fault paths Junhua Shen
2026-05-16  2:15   ` Claude review: " Claude Code Review Bot
2026-05-16  2:15 ` Claude review: drm/amdgpu: SVM VRAM migration via drm_pagemap (XNACK-on) Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260513095734.69598-6-Junhua.Shen@amd.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox