From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: renesas: Add Renesas R-Car V4H DSC Date: Sat, 16 May 2026 10:53:56 +1000 Message-ID: In-Reply-To: <20260514-rcar-du-dsc-v1-5-d65f7a9e9841@ideasonboard.com> References: <20260514-rcar-du-dsc-v1-0-d65f7a9e9841@ideasonboard.com> <20260514-rcar-du-dsc-v1-5-d65f7a9e9841@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Looks good.** The DTS changes correctly wire the DSC into the pipeline between DU and DSI1: - `du_out_dsi1` now points to `dsc_in_dsi1` (was `dsi1_in`) - DSC port@0 input connects to DU, port@1 output connects to DSI1 - `dsi1_in` now points to `dsc_out_dsi1` (was `du_out_dsi1`) The DSC node is `status = "disabled"` by default in the SoC dtsi, and the Sparrow Hawk board dts enables it: ```dts &dsc { status = "okay"; }; ``` One observation: this inserts the DSC unconditionally into the DSI1 pipeline at the SoC level. This means every board using DSI1 on this SoC must now also enable the DSC node. The cover letter confirms this matches the hardware topology (DSC is always between DU and DSI1 on V4H). The `status = "disabled"` default handles boards that don't use DSI1 at all. The node placement and properties (clocks, power-domains, resets matching module ID 2819 from patch 1) are consistent with the binding from patch 2. --- **Summary of required changes:** 1. **Patch 3:** Fix the bridge reference leak - use `devm_drm_of_get_bridge()` instead of `of_drm_find_and_get_bridge()`, or add explicit cleanup via `drm_bridge_put()`. --- Generated by Claude Code Patch Reviewer