From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Fold poweron and setup functions Date: Mon, 18 May 2026 16:41:45 +1000 Message-ID: In-Reply-To: <20260516183838.2024991-6-jonas@kwiboo.se> References: <20260516183838.2024991-1-jonas@kwiboo.se> <20260516183838.2024991-6-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status:** Correct. Merges the old `dw_hdmi_poweron()` wrapper into `dw_hdmi_setup()`, renaming `dw_hdmi_setup()` to `dw_hdmi_poweron()` with the connector and mode passed directly. The call site in `dw_hdmi_bridge_atomic_enable()` now retrieves the mode from crtc_state: ```c + crtc = drm_atomic_get_new_connector_state(state, connector)->crtc; + mode = &drm_atomic_get_new_crtc_state(state, crtc)->adjusted_mode; ``` No NULL checks on the return from `drm_atomic_get_new_connector_state()` or `drm_atomic_get_new_crtc_state()`, but these are guaranteed valid in `atomic_enable` since the connector is being enabled with a CRTC. --- Generated by Claude Code Patch Reviewer